Skip to content

feat(web): 멘토 수정 플로팅 버튼 및 합격 레시피 노출 #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manNomi merged 1 commit into from
Apr 26, 2026
Merged

feat(web): 멘토 수정 플로팅 버튼 및 합격 레시피 노출 #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/web/src/app/mentor/modify/_ui/ModifyContent/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const ModifyContent = () => {
</div>
</div>
</div>
<div className="mt-10">
<div className="mt-10 pb-36">
<h2 className="mb-2.5 text-primary-1 typo-sb-5">내 채널 관리</h2>
<ChannelBox channels={channels} />
{/* 4개의 고정된 채널 입력 필드 */}
Expand Down Expand Up @@ -96,8 +96,11 @@ const ModifyContent = () => {
<div className="mb-6">
<AddArticleCard />
</div>
<div className="mt-20 flex justify-center">
<button type="submit" className="mb-10 h-10 w-37.5 rounded-3xl bg-primary-1 px-5 py-2.5 text-k-0">
</div>

<div className="pointer-events-none fixed bottom-20 left-1/2 z-20 flex w-full -translate-x-1/2 justify-center">
<div className="pointer-events-auto px-5">
<button type="submit" className="h-10 w-37.5 rounded-3xl bg-primary-1 px-5 py-2.5 text-k-0">
수정하기
</button>
</div>
Expand Down
9 changes: 9 additions & 0 deletions apps/web/src/components/mentor/MentorCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const MentorCard = ({ mentor, observeRef, isMine = false }: MentorCardProps) =>
nickname,
universityName,
introduction,
passTip,
channels,
term,
id,
Expand Down Expand Up @@ -68,6 +69,14 @@ const MentorCard = ({ mentor, observeRef, isMine = false }: MentorCardProps) =>
<p className="text-k-500 typo-regular-2">{introduction}</p>
</div>

{/* 합격 레시피 */}
{isDetail && (
<div className="mb-4">
<h4 className="mb-2 text-blue-600 typo-medium-5">합격 레시피</h4>
<p className="text-k-500 typo-regular-2">{passTip || "정보가 없습니다."}</p>
</div>
)}
Comment on lines +72 to +78
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

2. 공백만 있는 합격 레시피도 빈 값으로 처리해 주세요.

- 지금은 `"   "` 같은 값이 들어오면 빈 화면처럼 보이지만 fallback 문구는 나오지 않습니다. PR 목표처럼 비어 있는 값에는 `정보가 없습니다.`가 보이도록 `trim()` 기준으로 판정하는 편이 안전합니다.
🐇 빠른 수정안 
-              <p className="text-k-500 typo-regular-2">{passTip || "정보가 없습니다."}</p>
+              <p className="text-k-500 typo-regular-2">{passTip?.trim() || "정보가 없습니다."}</p>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/components/mentor/MentorCard/index.tsx` around lines 72 - 78,
The passTip fallback currently uses truthiness so strings with only whitespace
like "   " bypass the fallback; update the render logic in MentorCard (symbols:
passTip, isDetail) to treat blank/whitespace-only values as empty by using
trim()—for example compute a display value (e.g., displayPassTip =
passTip?.trim() ? passTip : "정보가 없습니다.") or use a conditional expression
(passTip && passTip.trim() ? passTip : "정보가 없습니다.") when rendering the paragraph
so whitespace-only passTip shows "정보가 없습니다.".


{/* 멘토 채널 */}
<div className="mb-4">
<h4 className="mb-2 text-blue-600 typo-medium-5">멘토 채널</h4>
Expand Down
Loading