Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Walkthrough이 pull request는 멘토 기능 관련 두 개의 UI 개선사항을 포함합니다. 각 변경사항은 사용자 경험을 향상시키기 위한 레이아웃 및 표시 방식 개선을 다루고 있습니다.
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/web/src/components/mentor/MentorCard/index.tsx`:
- Around line 72-78: The passTip fallback currently uses truthiness so strings
with only whitespace like " " bypass the fallback; update the render logic in
MentorCard (symbols: passTip, isDetail) to treat blank/whitespace-only values as
empty by using trim()—for example compute a display value (e.g., displayPassTip
= passTip?.trim() ? passTip : "정보가 없습니다.") or use a conditional expression
(passTip && passTip.trim() ? passTip : "정보가 없습니다.") when rendering the paragraph
so whitespace-only passTip shows "정보가 없습니다.".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 8102a968-3786-4e71-9e4e-5cccdb27e215
📒 Files selected for processing (2)
apps/web/src/app/mentor/modify/_ui/ModifyContent/index.tsxapps/web/src/components/mentor/MentorCard/index.tsx
Comment on lines
+72
to
+78
| {/* 합격 레시피 */} | ||
| {isDetail && ( | ||
| <div className="mb-4"> | ||
| <h4 className="mb-2 text-blue-600 typo-medium-5">합격 레시피</h4> | ||
| <p className="text-k-500 typo-regular-2">{passTip || "정보가 없습니다."}</p> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
2. 공백만 있는 합격 레시피도 빈 값으로 처리해 주세요.
- 지금은 `" "` 같은 값이 들어오면 빈 화면처럼 보이지만 fallback 문구는 나오지 않습니다. PR 목표처럼 비어 있는 값에는 `정보가 없습니다.`가 보이도록 `trim()` 기준으로 판정하는 편이 안전합니다.
🐇 빠른 수정안
- <p className="text-k-500 typo-regular-2">{passTip || "정보가 없습니다."}</p>
+ <p className="text-k-500 typo-regular-2">{passTip?.trim() || "정보가 없습니다."}</p>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/web/src/components/mentor/MentorCard/index.tsx` around lines 72 - 78,
The passTip fallback currently uses truthiness so strings with only whitespace
like " " bypass the fallback; update the render logic in MentorCard (symbols:
passTip, isDetail) to treat blank/whitespace-only values as empty by using
trim()—for example compute a display value (e.g., displayPassTip =
passTip?.trim() ? passTip : "정보가 없습니다.") or use a conditional expression
(passTip && passTip.trim() ? passTip : "정보가 없습니다.") when rendering the paragraph
so whitespace-only passTip shows "정보가 없습니다.".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
/mentor/modify)의수정하기버튼을 하단 플로팅 버튼으로 변경했습니다.pb-36)을 추가했습니다.합격 레시피데이터를 기존 섹션 디자인과 동일한 스타일로 추가 노출했습니다.합격 레시피값이 비어있는 경우정보가 없습니다.문구를 표시하도록 처리했습니다.특이 사항
리뷰 요구사항 (선택)
수정하기버튼이 하단에 고정 노출되는지 확인 부탁드립니다.멘토 한마디아래합격 레시피가 정상 노출되는지 확인 부탁드립니다.