[dev] [Marfuen] mariano/fix-policy-publish-notifications

[github-actions]

This is an automated pull request to merge mariano/fix-policy-publish-notifications into dev.
It was created by the [Auto Pull Request] action.

---

Summary by cubic

Fixes policy publish notifications and adds a daily policy acknowledgment digest so eligible members get clear, batched reminders. Publishing now resets acknowledgments only on a true publish transition.

• New Features

  • Daily policyAcknowledgmentDigest task via @trigger.dev/sdk (14:00 UTC). Sends each compliance‑obligated member a digest of pending policies, batches to 25, respects org scoping, and handles multi‑org users.
  • Batched unsubscribe checks with getUnsubscribedEmails, reducing DB load and skipping opted‑out users.
  • New PolicyAcknowledgmentDigestEmail in @trycompai/email listing pending policies with portal links.

• Bug Fixes

  • Clear signedBy and set lastPublishedAt only when status transitions to published (not on no‑op updates).
  • publishAll now clears signedBy for each policy and uses filterComplianceMembers to target the right recipients.

^{Written for commit e60ed5c. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Ready	Preview, Comment	Apr 17, 2026 8:01pm
comp-framework-editor	Ready	Preview, Comment	Apr 17, 2026 8:01pm
portal	Ready	Preview, Comment	Apr 17, 2026 8:01pm

[cubic-dev-ai]

2 issues found across 10 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/email/lib/check-unsubscribe.ts">

<violation number="1" location="packages/email/lib/check-unsubscribe.ts:133">
P2: Skip member/role-setting queries when the preference type has no role-level mapping to avoid unnecessary DB work.</violation>
</file>

<file name="apps/app/src/trigger/tasks/task/policy-acknowledgment-digest-helpers.ts">

<violation number="1" location="apps/app/src/trigger/tasks/task/policy-acknowledgment-digest-helpers.ts:60">
P2: Handle invalid custom-role obligations JSON before parsing; the current unguarded `JSON.parse` can crash the digest task.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P2: Skip member/role-setting queries when the preference type has no role-level mapping to avoid unnecessary DB work.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/email/lib/check-unsubscribe.ts, line 133:

<comment>Skip member/role-setting queries when the preference type has no role-level mapping to avoid unnecessary DB work.</comment>

<file context>
@@ -51,6 +51,166 @@ interface RoleNotificationRecord {
+    const survivingEmails = survivingUsers.map((u) => u.email);
+
+    // Step 2: look up org roles for all surviving users in one query
+    const memberRecords = await db.member.findMany({
+      where: {
+        organizationId,
</file context>

[cubic-dev-ai]

P2: Handle invalid custom-role obligations JSON before parsing; the current unguarded JSON.parse can crash the digest task.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/app/src/trigger/tasks/task/policy-acknowledgment-digest-helpers.ts, line 60:

<comment>Handle invalid custom-role obligations JSON before parsing; the current unguarded `JSON.parse` can crash the digest task.</comment>

<file context>
@@ -0,0 +1,109 @@
+    });
+    customObligationMap = Object.fromEntries(
+      customRoles.map((r) => {
+        const obligations =
+          typeof r.obligations === 'string'
+            ? JSON.parse(r.obligations)
</file context>