feat(igc): add single-queue polling datapath#683
Open
ytakano wants to merge 4 commits intotier4:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an initial single-queue, polling-based TX/RX datapath for the Intel I225/I226 (igc) PCIe NIC, including DMA/bus-master enablement and minimal NetDevice wiring.
Changes:
- Enable PCIe bus-mastering (device + bridge) needed for DMA.
- Implement single-queue polling TX submission/reclaim and RX consume/refill, wired through
send(),recv(),can_send(), andcapabilities(). - Add a few igc descriptor constants required for advanced TX descriptors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| awkernel_drivers/src/pcie.rs | Enables BUS_MASTER (and forwarding bits on bridges) so endpoints can DMA through bridges. |
| awkernel_drivers/src/pcie/intel/igc.rs | Implements single-queue polling TX/RX datapath and integrates with the NetDevice trait. |
| awkernel_drivers/src/pcie/intel/igc/igc_defines.rs | Adds constants for advanced TX descriptor encoding (DTYP + PAYLEN shift). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
atsushi421
reviewed
Apr 22, 2026
atsushi421
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the first usable single-queue polling datapath for the Intel I225/I226 driver.
It enables the PCIe bus-mastering required for DMA, sets up single-queue TX/RX descriptor rings, and wires the minimal polling path through send(), recv(), can_send(), and capabilities(). It also adds TX reclamation based on TDH/TDT and RX consume/refill handling for the single-queue path.
This change is intentionally limited to the minimal end-to-end datapath. It does not add shell debug commands, NetDevice::debug_dump, IRQ RX buffering, multi-queue support, or checksum offload
Related links
How was this PR tested?
Real-machine smoke test:
Notes for reviewers