audio: pcm_converter: make global tables available to user-space#10722
Open
kv2019i wants to merge 1 commit intothesofproject:mainfrom
Open
audio: pcm_converter: make global tables available to user-space#10722kv2019i wants to merge 1 commit intothesofproject:mainfrom
kv2019i wants to merge 1 commit intothesofproject:mainfrom
Conversation
The pcm_converter depends on a set of global function tables to set up correct conversion functions. These objects need to be made available to user-space threads, so that pcm_converter can be also run in user-space. No impact to kernel-space use of pcm_converter. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
Copilot,
jsarha,
serhiy-katsyuba-intel and
singalsu
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
Author
|
Tested as part of bigger #10558 |
serhiy-katsyuba-intel
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PCM converter implementation so its global conversion/remapping function tables are placed into a userspace-accessible memory section, enabling pcm_converter to run from userspace threads without changing kernel-space behavior.
Changes:
- Annotate PCM converter function tables and their counts with
APP_TASK_DATAso they are available from Zephyr userspace memory domains. - Add
#include <rtos/userspace_helper.h>to the affected PCM converter source files to provideAPP_TASK_DATA.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/audio/pcm_converter/pcm_remap.c | Places pcm_remap_func_map / pcm_remap_func_count into userspace-accessible memory via APP_TASK_DATA. |
| src/audio/pcm_converter/pcm_converter_hifi3.c | Places HiFi3 pcm_func_map / pcm_func_count and pcm_func_vc_map / pcm_func_vc_count into userspace-accessible memory via APP_TASK_DATA. |
| src/audio/pcm_converter/pcm_converter_generic.c | Places generic pcm_func_map / pcm_func_count and pcm_func_vc_map / pcm_func_vc_count into userspace-accessible memory via APP_TASK_DATA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pcm_converter depends on a set of global function tables to set up correct conversion functions. These objects need to be made available to user-space threads, so that pcm_converter can be also run in user-space. No impact to kernel-space use of pcm_converter.