Skip to content

ASoC: sdw_utils: Add quirk to ignore sdca RT712/RT721 CODEC_MIC#5739

Open
macchian wants to merge 1 commit intothesofproject:topic/sof-devfrom
macchian:dev-pch-dmic
Open

ASoC: sdw_utils: Add quirk to ignore sdca RT712/RT721 CODEC_MIC#5739
macchian wants to merge 1 commit intothesofproject:topic/sof-devfrom
macchian:dev-pch-dmic

Conversation

@macchian
Copy link
Copy Markdown

When the sof driver selects the ACPI machine tables, some SKUs use the host PCH_DMIC;add quirk to ignore the CODEC_MIC if found in disco table.

When the sof driver selects the ACPI machine tables, some SKUs use
the host PCH_DMIC;add quirk to ignore the CODEC_MIC if found
in disco table.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a SoundWire machine-driver quirk mapping so specific SDCA Realtek codecs (RT712/RT721) can skip exposing their CODEC_MIC endpoint on SKUs that instead route microphone capture through the host PCH DMIC when ACPI machine tables are used.

Changes:

  • Mark RT712-SDCA MIC endpoint (aif3) with SOC_SDW_CODEC_MIC quirk and set it as an exclude-quirtk.
  • Mark RT721-SDCA MIC endpoint (aif3) with SOC_SDW_CODEC_MIC quirk and set it as an exclude-quirk.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@macchian
Copy link
Copy Markdown
Author

@lgirdwood , could you help review it? Thank you.

.dailink = {SOC_SDW_UNUSED_DAI_ID, SOC_SDW_DMIC_DAI_ID},
.rtd_init = asoc_sdw_rt_dmic_rtd_init,
.quirk = SOC_SDW_CODEC_MIC,
.quirk_exclude = true,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needs Fixes tag?

Also, quote from the commit message: "some SKUs use the host PCH_DMIC"
what about the other SKUs?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is optional only for specific topology files that use PCH_DMIC but SDW_DMIC. Other SKUs use either PCH_DMIC or SDW_DMIC with functional topology separately.

@macchian macchian requested a review from ujfalusi April 23, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants