Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31737198a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <NewsSectionDynamic newsList={newsList} /> | ||
|
|
||
| <SiteFooter /> | ||
| </div> |
There was a problem hiding this comment.
This change removes <SiteFooter /> from the home page render, but apps/web/src/app/(home)/_ui/SiteFooter/index.tsx is still the only place that exposes the site's business information; after this commit that footer is no longer reachable anywhere in apps/web/src/app. This is a user-facing regression from the previous behavior and can hide required disclosure content on the main entry page.
Useful? React with 👍 / 👎.
| response.cookies.set({ | ||
| name: NEED_LOGIN_COOKIE_KEY, | ||
| value: "true", | ||
| path: "/", | ||
| sameSite: "lax", | ||
| maxAge: 60, |
There was a problem hiding this comment.
buildLoginRedirectResponse always sets the isNeedLogin cookie when redirecting unauthenticated requests, including speculative requests. Since the app uses default-prefetch Links in bottom navigation to protected routes (/community, /mentor, /my), middleware can set this cookie during background prefetch and later trigger a misleading "로그인이 필요합니다" toast even when the user did not explicitly attempt a protected action. The cookie write should be limited to real navigations (non-prefetch requests).
Useful? React with 👍 / 👎.
1 participant
요약
/mentor,/my,/community)에서refreshToken을 기존 JWT 유틸(isTokenExpired)로 검증하도록 변경했습니다./login으로 리디렉션하도록 처리했습니다.isNeedLogin쿠키 → Zustand(isNeedLogin) 브릿지 방식으로 전환했습니다.isNeedLogin이 true일 때 로그인 필요 토스트를 1회 노출하고 플래그를 즉시 정리하도록 구현했습니다.교환학생 사이트 | 솔리드 커넥션 – 교환학생 커뮤니티, 플랫폼)로 맞추고 OpenGraph/Twitter 타이틀도 일치시켰습니다.변경 파일
apps/web/src/middleware.tsapps/web/src/lib/zustand/useAuthStore.tsapps/web/src/app/login/LoginContent.tsxapps/web/src/utils/jwtUtils.tsapps/web/src/app/(home)/page.tsx검증
pnpm --filter @solid-connect/web exec biome check 'src/app/(home)/page.tsx' src/app/login/LoginContent.tsx src/lib/zustand/useAuthStore.ts src/middleware.ts src/utils/jwtUtils.tspnpm --filter @solid-connect/web typecheck