improvement(codebase): centralize test mocks, extract @sim/utils, remove dead code#4228
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
PR SummaryMedium Risk Overview Refactors the test suite to prefer centralized module mocks from Reviewed by Cursor Bugbot for commit 6a0db71. Configure here. |
858b89b to
3bcf71b
Compare
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3bcf71b. Configure here.
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6a0db71. Configure here.
Summary
@sim/utilspackage — extractedid,helpers,errors,formattingfromapps/simto eliminate UUID generation inconsistency between app andpackages/db@sim/testing(auth, hybrid-auth, schema, env, request, audit, encryption, input-validation, redis-config, workflows-api-utils, knowledge-api-utils, logging-session, workflows-persistence-utils, workflows-orchestration, auth-oauth-utils, copilot-http, execution-preprocessing)vi.hoisted()boilerplate to centralized mocks (−558 LoC from migration alone)api.mock.ts,uuid.mock.ts, deprecatedmockAuth()/mockHybridAuth()helpers, obsolete doc warningsnew Promise(setTimeout)withsleep()from@sim/utils/helpersconsole.*calls in source files with@sim/logger.claudeand.cursortesting rules with the centralized-mocks lookup tableType of Change
Testing
Checklist