Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes a small lifecycle command test gap in the ILM rule bucket path parser.
The
ilm rulecommands document bucket paths asalias/bucket, but the parser previously split at the first slash and accepted paths such aslocal/my-bucket/key.txt. That treatedmy-bucket/key.txtas the bucket name, so an object-style path could get past local validation and fail later as a confusing bucket lookup or backend request.The fix keeps trailing slashes valid for bucket paths while rejecting any non-empty path segments after the bucket. The added regression assertions cover both one-segment and nested object keys.
Validation
cargo test -p rustfs-cli commands::ilm::rule::tests::test_parse_bucket_path_errorcargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspacemake pre-commitwas requested, but this repository checkout has noMakefileand nopre-committarget, so it could not be run.