fix bug: issue #3595 and add unit test #3661
Open
kael-aiur wants to merge 3 commits intoredis:mainfrom
Open
Conversation
2 tasks
Contributor
|
Thanks @kael-aiur |
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Author
|
I think the test fail on redis 7.4 and 8.2 is appears to be a flaky test unrelated to my changes. The test failure is in scriptLoad() which is unrelated to the clusterMyId() fallback logic I modified? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Medium Risk
Changes stale-connection detection used during partition reconfiguration, which can affect connection lifecycle and traffic routing during failover. Scope is small and covered by a new unit test, but incorrect role detection could cause extra reconnects or missed closures.
Overview
Fixes stale-connection detection during cluster partition updates so cached connections are treated as stale when the node’s current role no longer matches the connection intent (e.g., a
READconnection pointing at an upstream/master, or aWRITEconnection pointing at a replica).Adds a unit test ensuring a cached read-from-replica connection is closed when that replica is promoted to master after
setPartitions().Written by Cursor Bugbot for commit 160ebad. This will update automatically on new commits. Configure here.