gh-149141: Fix test discovery failure when srcpath contains symlink(s)#149143
Open
neek78 wants to merge 7 commits intopython:mainfrom
Open
gh-149141: Fix test discovery failure when srcpath contains symlink(s)#149143neek78 wants to merge 7 commits intopython:mainfrom
neek78 wants to merge 7 commits intopython:mainfrom
Conversation
neek78
changed the title
Member
|
Just for the future: don't merge main into your branch if there is no conflict to solve. See https://devguide.python.org/getting-started/pull-request-lifecycle/#update-branch-button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-149141: Fix test discovery when src tree path contains symlink(s)
_get_name_from_path() compares paths as provided to ensure one is a
subdir of the other. This fails when one is a symlink'd path and the other
is not. Resolve both to realpath first to fix this.