Skip to content

gh-149122: Fix segfault in compiler when certain builtin functions are passed a coroutine as arg#149138

Merged
iritkatriel merged 3 commits intopython:mainfrom
iritkatriel:gh-149122
Apr 29, 2026
Merged

gh-149122: Fix segfault in compiler when certain builtin functions are passed a coroutine as arg#149138
iritkatriel merged 3 commits intopython:mainfrom
iritkatriel:gh-149122

Conversation

@iritkatriel
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel commented Apr 29, 2026 •
edited by bedevere-app Bot
Loading

Fixes #149122.

Disables the builtin-on-genexpr optimisation when the genexpr is a coroutine.

@bedevere-app bedevere-app Bot mentioned this pull request Apr 29, 2026
Closed
@iritkatriel iritkatriel added type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.14 bugs and security fixes release-blocker labels Apr 29, 2026
@iritkatriel iritkatriel requested a review from carljm April 29, 2026 08:45
@kumaraditya303
Copy link
Copy Markdown
Contributor

kumaraditya303 commented Apr 29, 2026

I think this deserves a bug news entry.

@iritkatriel iritkatriel enabled auto-merge (squash) April 29, 2026 13:05
@iritkatriel iritkatriel merged commit 16f292e into python:main Apr 29, 2026
54 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Apr 29, 2026

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 29, 2026

GH-149151 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 29, 2026
iritkatriel added a commit that referenced this pull request Apr 29, 2026
@miss-islington @iritkatriel
[3.14] gh-149122: Fix segfault in compiler when certain builtin funct…
098880d 
…ions are passed a coroutine as arg (GH-149138) (#149151)

gh-149122: Fix segfault in compiler when certain builtin functions are passed a coroutine as arg (GH-149138)
(cherry picked from commit 16f292e)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
manoj-km24 pushed a commit to manoj-km24/cpython that referenced this pull request Apr 29, 2026
@iritkatriel @manoj-km24
pythongh-149122: Fix segfault in compiler when certain builtin functi…
4d85f9a 
…ons are passed a coroutine as arg (python#149138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@carljm carljm Awaiting requested review from carljm

Assignees

No one assigned

Labels

release-blocker type-crash A hard crash of the interpreter, possibly with a core dump

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segfault with async generator expressions

2 participants

@iritkatriel @kumaraditya303