gh-149000: Fix race / leak in pickle XID per-interpreter cae#149002
Open
CharlieKerfoot wants to merge 5 commits intopython:mainfrom
Open
gh-149000: Fix race / leak in pickle XID per-interpreter cae#149002CharlieKerfoot wants to merge 5 commits intopython:mainfrom
CharlieKerfoot wants to merge 5 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
…eKerfoot/cpython into fix-pickle-xid-cache-race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix issue #149000, I replace the load/store with an atomic compare-exchange. The fast path is a relaxed atomic load.
Population imports the attribute, then attempts to CAS it into the slot. On a lost CAS, the loser
Py_DECREFs its own reference and returns the winner's pointer (now owned by the slot).
Used a helper _cache_pickle_attr() because the logic was the same for the dumps and loads getters.
Tests
Existing test_interpreters / InterpreterPoolExecutor tests still pass under the GIL build
Same under --disable-gil
Fixed issue: #149000