A redis-backed storage backend#1170
Open
stefanor wants to merge 2 commits intoprometheus:masterfrom
Open
Conversation
Rather than relying on MultiProcessCollector to accummulate it Signed-off-by: Stefano Rivera <stefano@rivera.za.net>
stefanor
force-pushed
the
redis-values
branch
5 times, most recently
from
393866e to
be66455
Compare
Signed-off-by: Stefano Rivera <stefano@rivera.za.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multiprocess backend has an issue with database file explosion (#204, #518, etc.)
In the environment that I'm running into this problem, we have a redis database available, so why not take advantage of this?
Here is a very naive proof-of-concept example. It doesn't add the pid labels that the multiprocess backend does (I have no need for them). But it could be extended to do so.
Also compatible with Valkey.