A few edits on your v3.1 PR#15
Open
fenollp wants to merge 17 commits intooasdiff:feat/openapi-3.1-supportfrom
Open
A few edits on your v3.1 PR#15fenollp wants to merge 17 commits intooasdiff:feat/openapi-3.1-supportfrom
fenollp wants to merge 17 commits intooasdiff:feat/openapi-3.1-supportfrom
Conversation
…penAPI31OrLater and doc.OpenAPIMajorMinor Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
…1OrLater Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
…idationOption) error Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
…TLS for v3.0 Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for tackling this, especially the schema part!
I think this should move forward as-is however I have a few points:
Regarding v3.1 sibling fields: this was missing tests which I added. One test (for v3.0) is not passing so please take a look. Also please complete the implementation of
applySiblingSchemaFields. I can't merge this with this regression for 3.0.Be more careful when adding new v3.1 capabilities in general: things have to be gated with
IsOpenAPI31OrLater()! So please go over the Schema's Validate func and gate the usage of v3.1 fields.I renamed some things and decoupled the options "isopenapiv3.1" and "usenewschema". Because the first is required when validating oas documents and the later will end up being a noop once I replace v3.0's custom schema validation with the new one.
Oh let's try to not squash the commits please.