Conversation
…d/nvQuickTheme into update-to-use-npm-vite
There was a problem hiding this comment.
All looks good, @tksheppard , except for the old-docs folder and files that should have been removed .
Never mind me, @tksheppard...
david-poindexter
left a comment
david-poindexter
left a comment
There was a problem hiding this comment.
This is only a partial review. I'll finish the review of other areas as soon as I can.
| "android >= 4", | ||
| "bb >= 10" | ||
| ] | ||
| "@fortawesome/fontawesome-free": "^7.0.1", |
There was a problem hiding this comment.
This should be in dependencies instead of devDependencies.
There was a problem hiding this comment.
@tksheppard just making sure you saw this from last month.
| ] | ||
| "@fortawesome/fontawesome-free": "^7.0.1", | ||
| "archiver": "^6.0.1", | ||
| "bootstrap": "^5.3.8", |
There was a problem hiding this comment.
This should be in dependencies instead of devDependencies.
There was a problem hiding this comment.
@tksheppard just making sure you saw this from last month.
| @@ -0,0 +1,7 @@ | |||
| export default { | |||
| dnnUrl: 'https://2sxc-19.me', | |||
There was a problem hiding this comment.
This should be something more generic for the public, like nvquicktheme.loc.
There was a problem hiding this comment.
@tksheppard just making sure you saw this from last month.
There was a problem hiding this comment.
@tksheppard why was this file deleted? This is used for the GitHub issue template (which should still be valid).
There was a problem hiding this comment.
@tksheppard why was this file deleted? This is used for the GitHub issue template (which should still be valid).
There was a problem hiding this comment.
@tksheppard why was this file deleted? This is used for the GitHub issue template (which should still be valid).
There was a problem hiding this comment.
@tksheppard why was this file deleted? This is used for the GitHub issue template (which should still be valid).
There was a problem hiding this comment.
@tksheppard why was this file deleted? This is used the GitHub Actions CI build.
There was a problem hiding this comment.
@tksheppard why was this file deleted? This is used for GitHub Sponsors.
There was a problem hiding this comment.
@tksheppard why was this file deleted? This is used for the GitHub pull request template (which should still be valid).
There was a problem hiding this comment.
@tksheppard is there a reason why this file name changed? I am not sure if GitHub supports it with this naming. GitHub has a feature to auto-detect the LICENSE file and display the correct license type in other areas of the GitHub repo UI.
| { | ||
| "project": "nvQuickTheme", | ||
| "version": "3.2.0", | ||
| "version": "4.0.0", |
There was a problem hiding this comment.
| "version": "4.0.0", | |
| "version": "1.0.0", |
There was a problem hiding this comment.
@tksheppard why was this file deleted? This GitHub repo needs a README.md.
There was a problem hiding this comment.
@tksheppard as a first step, please convert this to TypeScript. I'll review it more granularly after that.
3 participants
Related to Issue
Fixes #356
Description
This PR aims to update the build system and task automation to leverage Vite. This should help compilation speeds greatly. And bring us up-to-date on technology. New docs made, old docs are kept as reference in case we want to reuse anything (can eventually be removed).
How Has This Been Tested?
Build tested, packaging tested, watch and serve tested. @dnndiva also setup and ran it succesfully, as well as helped find issues.
Screenshots (if appropriate):
Types of changes
Checklist: