Open
Conversation
codingLogan
requested review from
Jameson13B,
ash-wright123,
mwclemy and
wesrisenmay-mx
as code owners
…us to unavailable Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…at mxui/mui provide
|
approved pending changes to the placement of the chip. will need to revisit chip and change styling once available in MXUI. |
Co-authored-by: Copilot <copilot@github.com>
| action.payload.institution && | ||
| (institutionIsBlockedForCostReasons(action.payload.institution) || | ||
| action.payload.institutionStatus === InstitutionStatus.UNAVAILABLE) | ||
| action.payload.institutionStatus === InstitutionStatus.UNAVAILABLE || |
Collaborator
There was a problem hiding this comment.
It's probably worth using the same pattern you used on line 550 with the includes here
| status: InstitutionStatusField.UNAVAILABLE, | ||
| } | ||
| const unavailableInstitutions: { guid: string; name: string }[] = [] | ||
| vi.mocked(institutionBlocks.institutionIsBlockedForCostReasons).mockReturnValue(false) |
Collaborator
There was a problem hiding this comment.
Better to make this fail in a real way than mock it
| status: InstitutionStatusField.UNAVAILABLE, | ||
| } | ||
| const store = createMockStore([]) | ||
| vi.mocked(institutionBlocks.institutionIsBlockedForCostReasons).mockReturnValue(false) |
| const filteredPopularInstitutions = updatedPopularInstitutions.filter((popular) => { | ||
| const status = getInstitutionStatus(popular, unavailableInstitutions) | ||
| return ( | ||
| status !== InstitutionStatus.UNAVAILABLE && |
Collaborator
There was a problem hiding this comment.
Seems worth making an abstraction based on how many times I'm seeing the status checked for both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mxcom.atlassian.net/browse/CTT-70
Changes
statusandclient_statusfield available, if the API passes them to the widget.Tangent areas
Screenshots