Skip to content

Add additional descriptions of the device#193

Open
moritzstaffel wants to merge 5 commits intonextfrom
Add-additional-descriptions-of-the-device
Open

Add additional descriptions of the device#193
moritzstaffel wants to merge 5 commits intonextfrom
Add-additional-descriptions-of-the-device

Conversation

@moritzstaffel
Copy link
Copy Markdown
Contributor

@moritzstaffel moritzstaffel commented Apr 18, 2024

Implements #45

@moritzstaffel moritzstaffel self-assigned this Apr 18, 2024
@moritzstaffel moritzstaffel changed the base branch from main to next April 18, 2024 12:28
@moritzstaffel
Copy link
Copy Markdown
Contributor Author

moritzstaffel commented Apr 18, 2024

Summery of discussion:
The distance need more definition, as it is not clear what they actually do and how do we define this.
Laser, CO2 Cannon, Pyro: Do they need this as well.

moritzstaffel
moritzstaffel commented Apr 25, 2024
View reviewed changes
Comment thread gdtf-spec.md Outdated
| XML Attribute Name | Value Type | Description |
|----|----|----|
| IPRating | [String](#user-content-attrtype-string ) | IP Rating of the device of the format of IEC 60529. Example: IP65 |
| DistanceToFlammable | [Float](#user-content-attrtype-float ) | Minimal distance in meter from flammable objects; Default value: 0 |
Copy link
Copy Markdown
Contributor Author

@moritzstaffel moritzstaffel Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do the DistanceToFlammable

moritzstaffel
moritzstaffel commented Apr 25, 2024
View reviewed changes
Comment thread gdtf-spec.md Outdated
|----|----|----|
| IPRating | [String](#user-content-attrtype-string ) | IP Rating of the device of the format of IEC 60529. Example: IP65 |
| DistanceToFlammable | [Float](#user-content-attrtype-float ) | Minimal distance in meter from flammable objects; Default value: 0 |
| DistanceToIlluminated | [Float](#user-content-attrtype-float ) | Minimal distance in meter from other objects; Default value: 0 |
Copy link
Copy Markdown
Contributor Author

@moritzstaffel moritzstaffel Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DistanceToTarget

Minimal distance to the target of the device. For Lasers, WaterFountains, Audio and Lighting devices.

@petrvanekrobe
Copy link
Copy Markdown
Contributor

petrvanekrobe commented May 2, 2024

  • Robe defined data: Min. distance from flammable materials: 1 m is a required information about distance from flammable materials based on surface temperature of the fixture's housing. This is defined in EN IEC 60598-2-17 part 2-17, section 17.6.4 - minimal distance from flammable materials of all outer surfaces of the device.

  • Robe defined data: Min. distance of illuminated objects: 18 m is a required information about distance on which the fixture could make illuminated surface warmer then 90°. This is defined in EN IEC 60598-1, part 1, section 3.2.13. Often accommodated by this picture:

image

@petrvanekrobe petrvanekrobe force-pushed the Add-additional-descriptions-of-the-device branch from b5461cf to a4c5342 Compare March 24, 2026 17:55
@petrvanekrobe petrvanekrobe force-pushed the Add-additional-descriptions-of-the-device branch 2 times, most recently from 444e2f2 to 674e61c Compare April 2, 2026 10:03
danielmuellerma
danielmuellerma reviewed Apr 7, 2026
View reviewed changes
Comment thread gdtf-spec.md Outdated

| XML Attribute Name | Value Type | Description |
|----|----|----|
| IPRating | [String](#user-content-attrtype-string ) | IP Rating of the device in the format of IEC 60529. Example: IP65 |
Copy link
Copy Markdown
Contributor

@danielmuellerma danielmuellerma Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add "Optional" to the description of both.

Copy link
Copy Markdown
Contributor

@petrvanekrobe petrvanekrobe Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to all.

danielmuellerma
danielmuellerma reviewed Apr 7, 2026
View reviewed changes
Comment thread gdtf-spec.md Outdated
| XML Attribute Name | Value Type | Description |
|----|----|----|
| DistanceToFlammable | [Float](#user-content-attrtype-float ) | Minimal distance from flammable materials of all outer surfaces of the device according to IEC 60598-2-17; Unit: meter; Default value: 0 |
| DistanceToFlammable | [Float](#user-content-attrtype-float ) | Optional. Minimal distance from flammable materials of all outer surfaces of the device according to IEC 60598-2-17; Unit: meter; Default value: 0 |
Copy link
Copy Markdown
Contributor

@danielmuellerma danielmuellerma Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that "optional" and a default value cannot exist at the same time. In this case, I think a default value of 0 is better.

Copy link
Copy Markdown
Contributor

@petrvanekrobe petrvanekrobe Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I edited it.

@petrvanekrobe petrvanekrobe force-pushed the Add-additional-descriptions-of-the-device branch from 7b72416 to bc15b60 Compare April 7, 2026 18:52
@petrvanekrobe petrvanekrobe force-pushed the Add-additional-descriptions-of-the-device branch from bc15b60 to 01b0edd Compare April 10, 2026 07:31
klinzey
klinzey reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@klinzey klinzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a device have both and IEC 60529 and an IEC 62262 rating? if so Raring needs to allow for more than 1.

klinzey
klinzey requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@klinzey klinzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Minimal distance from flammable materials ..."
should be
"Minimum distance from flammable materials ..."

@danielmuellerma danielmuellerma requested a review from klinzey April 22, 2026 05:03
@petrvanekrobe
Copy link
Copy Markdown
Contributor

petrvanekrobe commented Apr 22, 2026

Could a device have both and IEC 60529 and an IEC 62262 rating? if so Raring needs to allow for more than 1.

As these are attributes of Ratings, the Ratings is present or not. If yes, then the IKRating or IPRating might or might not be present:

<Ratings IPRating="xx" IKRating="xx" />

Thank you @danielmuellerma for the edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrvanekrobe petrvanekrobe petrvanekrobe left review comments

@klinzey klinzey klinzey approved these changes

@danielmuellerma danielmuellerma danielmuellerma approved these changes

Assignees

@petrvanekrobe petrvanekrobe

Labels

gdtf spec in work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moritzstaffel @petrvanekrobe @klinzey @danielmuellerma