Conversation
* `is-any-array` and `ml-array-rescale` are bundled into `ml-matrix` build: build mjs with rollup Remove `build-esm-facade.mjs`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 64.83% 64.83%
=======================================
Files 47 47
Lines 5625 5625
Branches 954 954
=======================================
Hits 3647 3647
Misses 1967 1967
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d8d5aec to
e0cfc27
Compare
|
@targos It should be good |
|
I will review tomorrow |
targos
left a comment
There was a problem hiding this comment.
I'm thinking about: "module": "src/index.js", (for bundlers). We should probably keep the deps in prod dependencies for this use case.
|
I did not pay attention, |
|
The idea is to point to the source code to make tree shaking potentially more effective, but I have no strong opinion. |
|
Where is the documentation of this
|
|
It's used by bundlers. e.g. https://rollupjs.org/introduction/#publishing-es-modules |
|
Ok to keep deps instead devDeps so. |
bundle
is-any-arrayandml-array-rescaleintoml-matrixbuild: build
mjswithrollupRemove
build-esm-facade.mjsscriptbuild: add sourcemaps