Skip to content

fix: bundle array deps#204

Merged
tpoisseau merged 4 commits intomainfrom
upgrade-array-deps-and-bundle
Apr 15, 2026
Merged

fix: bundle array deps#204
tpoisseau merged 4 commits intomainfrom
upgrade-array-deps-and-bundle

Conversation

@tpoisseau
Copy link
Copy Markdown
Contributor

@tpoisseau tpoisseau commented Apr 14, 2026

bundle is-any-array and ml-array-rescale into ml-matrix

build: build mjs with rollup

Remove build-esm-facade.mjs script

build: add sourcemaps

* `is-any-array` and `ml-array-rescale` are bundled into `ml-matrix`

build: build mjs with rollup

Remove `build-esm-facade.mjs`
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.83%. Comparing base (b398a84) to head (dcfd6f7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   64.83%   64.83%           
=======================================
  Files          47       47           
  Lines        5625     5625           
  Branches      954      954           
=======================================
  Hits         3647     3647           
  Misses       1967     1967           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tpoisseau tpoisseau requested a review from targos April 14, 2026 12:43
@tpoisseau tpoisseau changed the title fix: bundle array deps fix: bundle array deps Apr 14, 2026
@tpoisseau tpoisseau force-pushed the upgrade-array-deps-and-bundle branch from d8d5aec to e0cfc27 Compare April 14, 2026 12:59
@tpoisseau
Copy link
Copy Markdown
Contributor Author

@targos It should be good

@targos
Copy link
Copy Markdown
Member

targos commented Apr 14, 2026

I will review tomorrow

Copy link
Copy Markdown
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about: "module": "src/index.js", (for bundlers). We should probably keep the deps in prod dependencies for this use case.

@tpoisseau
Copy link
Copy Markdown
Contributor Author

I did not pay attention,
Should not we use "module": "matrix.mjs" ?

@targos
Copy link
Copy Markdown
Member

targos commented Apr 15, 2026

The idea is to point to the source code to make tree shaking potentially more effective, but I have no strong opinion.

@tpoisseau
Copy link
Copy Markdown
Contributor Author

Where is the documentation of this module field ?

@targos
Copy link
Copy Markdown
Member

targos commented Apr 15, 2026

It's used by bundlers. e.g. https://rollupjs.org/introduction/#publishing-es-modules

@tpoisseau
Copy link
Copy Markdown
Contributor Author

Ok to keep deps instead devDeps so.

@tpoisseau tpoisseau merged commit 94360fe into main Apr 15, 2026
11 checks passed
@tpoisseau tpoisseau deleted the upgrade-array-deps-and-bundle branch April 15, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants