envFile parser: support slash-delimited key names (Consul-style variables)#1009
Open
ANPewansmith wants to merge 3 commits intomicrosoft:mainfrom
Open
envFile parser: support slash-delimited key names (Consul-style variables)#1009ANPewansmith wants to merge 3 commits intomicrosoft:mainfrom
ANPewansmith wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Allow use of consul-style forward slash env variables
Added tests for consul-style env vars
Contributor
|
@ANPewansmith please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parseEnvLineuses/^\s*(_*[a-zA-Z]\w*)\s*=\s*(.*?)?\s*$/to match env var names.\wonly allows[A-Za-z0-9_], so keys containing/(e.g.globals/my_storage_dir=/some/path) are silently dropped — the line matches nothing and is discarded without error.This affects users whose services use slash-namespaced config keys, a common pattern with Consul (used widely in enterprise deployments). The variables appear in the envFile but are silently ignored, when overriding Consul variables for local development this is extremely difficult to diagnose.
Fix
Change the key character class from
\w*to[\w/]*to allow/in key names.Notes
envdict in launch.json configs already supports these keys without restriction so this alignsenvFilebehaviour with it