Remove dead extract_knowledge_for_text_batch_q function#259
Merged
gvanrossum merged 1 commit intomicrosoft:mainfrom Apr 29, 2026
Merged
Remove dead extract_knowledge_for_text_batch_q function#259gvanrossum merged 1 commit intomicrosoft:mainfrom
gvanrossum merged 1 commit intomicrosoft:mainfrom
Conversation
This function only raised NotImplementedError and was never called anywhere in the codebase (confirmed by grep). No imports became orphaned after removal.
KRRT7
force-pushed
the
cleanup-dead-knowledge-fn
branch
from
9a3faeb to
db84334
Compare
gvanrossum
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_knowledge_for_text_batch_qfromknowledge.py— a stub that only raisedNotImplementedErrorwith no callersconcurrency=2default inconsistency; turns out the function is dead code)Test plan