[Android Only] Fixing HTTP DELETE/HEAD/OPTIONS/PATCH requests silentlty sent as GET#962
Open
jasonsandlin wants to merge 1 commit intomainfrom
Open
[Android Only] Fixing HTTP DELETE/HEAD/OPTIONS/PATCH requests silentlty sent as GET#962jasonsandlin wants to merge 1 commit intomainfrom
jasonsandlin wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression in commit 80d9d8c (PR #880 — progress report callbacks) causes HTTP requests using DELETE, HEAD, OPTIONS, or PATCH with no body to be silently sent as GET on Android. The
requestBuilder.method()call was moved inside a POST/PUT-only conditional, so all other verbs never have their method set on OkHttp's Request.Builder.Repro: Any Android HTTP call using DELETE with no request body (e.g.,
HCHttpCallRequestSetMethod(call, "DELETE")).Impact: All libHttpClient Android consumers using DELETE/HEAD/OPTIONS/PATCH with no body. Requests succeed but hit the wrong server endpoint or return 405.
Fix: Commit 61f081b — move
requestBuilder.method()outside the conditional so it runs for all HTTP verbs. Also add PATCH to the empty-body creation list (OkHttp requires non-null body for PATCH).