Skip to content

add .clangd#2421

Open
446564 wants to merge 1 commit intomeshcore-dev:devfrom
446564:ig-clangd
Open

add .clangd#2421
446564 wants to merge 1 commit intomeshcore-dev:devfrom
446564:ig-clangd

Conversation

@446564
Copy link
Copy Markdown
Contributor

@446564 446564 commented Apr 27, 2026

No description provided.

@446564
Copy link
Copy Markdown
Contributor Author

446564 commented Apr 27, 2026

@recrof easy one

@recrof
Copy link
Copy Markdown
Member

recrof commented Apr 27, 2026

@liamcottle can we merge please?

@ripplebiz
Copy link
Copy Markdown
Member

As far as I know, the .clangd files are typically committed. Not an expert tho

@446564
Copy link
Copy Markdown
Contributor Author

446564 commented Apr 28, 2026

Happy to do that instead, it's just flags to either include or not and some rules for clangtidy.

@446564 446564 changed the title add .clangd to .gitignores add .clangd Apr 28, 2026
@446564
Copy link
Copy Markdown
Contributor Author

446564 commented Apr 28, 2026

@liamcottle if you merge, and want to keep the tidy stuff, you should also follow up with a commit that has run clang tidy on the codebase or PR will have tons of formatting changes. we can also remove the tidy portion for now, until we settle on some style guidlines or rules to apply anyway.

@liamcottle
Copy link
Copy Markdown
Member

@446564 I'm happy for the config/rules to apply to newly added code, before it's commit, but would prefer that none of this ever auto updates existing code in irrelevant files. Otherwise PRs become a mess to review.

PRs should only change what is necessary. It's annoying when someone adds a new feature that's a 2 line change, but it comes with a 600 line file reformat.

So I guess, no auto tidy for now then..?

@446564
Copy link
Copy Markdown
Contributor Author

446564 commented Apr 29, 2026

@446564 I'm happy for the config/rules to apply to newly added code, before it's commit, but would prefer that none of this ever auto updates existing code in irrelevant files. Otherwise PRs become a mess to review.

PRs should only change what is necessary. It's annoying when someone adds a new feature that's a 2 line change, but it comes with a 600 line file reformat.

So I guess, no auto tidy for now then..?

That will only affect files modified in commits, unless someone intentionally runs it against the whole project. And I just remembered this is only diagnostic.. 😮‍💨 so it won't change anything but suggest these changes as hints in editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants