Fix: Lillygo Tbeam 1W Fan Control and LNA Sequencing improvements #2418
Open
Robowarrior834 wants to merge 7 commits intomeshcore-dev:devfrom
Open
Fix: Lillygo Tbeam 1W Fan Control and LNA Sequencing improvements #2418Robowarrior834 wants to merge 7 commits intomeshcore-dev:devfrom
Robowarrior834 wants to merge 7 commits intomeshcore-dev:devfrom
Conversation
Robowarrior834
changed the title
Author
|
Had to rebuild the repository as I accidently added other local changes I made on my machine to the old pull request |
ripplebiz
reviewed
Apr 28, 2026
| #ifdef DISPLAY_CLASS | ||
| ui_task.loop(); | ||
| #endif | ||
| rtc_clock.tick(); |
Member
There was a problem hiding this comment.
Is probably time to introduce a new virtual MainBoard::loop(), and a no-op as default.
And have the TBeam1WBoard class override, and put the updateFan() logic there
| setFanEnabled(true); | ||
| _fan_off_millis = millis() + 10000; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
ie. here make this the board's loop() method
Author
There was a problem hiding this comment.
So I did this. Would I also need to add a loop function to every variant?
Author
There was a problem hiding this comment.
I answered my own question. Added a new virtual loop to the mainboard class so other variants compile and adjusted the tbeam 1w to override.
Co-authored-by: Copilot <copilot@github.com>
…s is needed for the TBeam1W board to update the fan state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures proper sequencing of the LNA and amp for the TBEAM 1W. Also adds fan control to keep the fan on for 10 seconds.