Skip to content

ci: skip functions workflow on doc-only changes#3631

Open
Ankitsinghsisodya wants to merge 2 commits intoknative:mainfrom
Ankitsinghsisodya:ci/paths-ignore-functions
Open

ci: skip functions workflow on doc-only changes#3631
Ankitsinghsisodya wants to merge 2 commits intoknative:mainfrom
Ankitsinghsisodya:ci/paths-ignore-functions

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

@Ankitsinghsisodya Ankitsinghsisodya commented Apr 22, 2026

Closes #3634

Summary

  • Adds paths-ignore filters to both push and pull_request triggers in the Functions CI workflow
  • Skips the full CI suite (unit, template, integration, e2e) when only documentation or non-code files are changed
  • Ignored paths: docs/**, **/*.md, CODEOWNERS, LICENSE

Motivation

The Functions workflow spawns many expensive jobs (unit tests across 5 OSes, integration tests, 7-runtime E2E matrix). Running all of these on a docs-only commit wastes CI minutes and runner time.

Test plan

  • Open a PR that only modifies a .md file — verify Functions workflow is skipped
  • Open a PR that modifies a .go file — verify Functions workflow still runs

Add paths-ignore to push and pull_request triggers to avoid
running the full CI suite (unit, template, integration, e2e)
when only documentation or non-code files are modified.
Copilot AI review requested due to automatic review settings April 22, 2026 15:16
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos April 22, 2026 15:16
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added size/S 🤖 PR changes 10-29 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Apr 22, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 22, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Functions GitHub Actions workflow to avoid running the expensive Functions CI suite when changes are limited to documentation/non-code paths.

Changes:

  • Add paths-ignore filters to push triggers on main.
  • Add paths-ignore filters to pull_request triggers targeting main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/functions.yaml Outdated
Comment thread .github/workflows/functions.yaml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.43%. Comparing base (7247657) to head (15f5a96).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3631      +/-   ##
==========================================
+ Coverage   56.33%   58.43%   +2.09%     
==========================================
  Files         180      180              
  Lines       20571    20572       +1     
==========================================
+ Hits        11589    12021     +432     
+ Misses       7780     7348     -432     
- Partials     1202     1203       +1     
Flag Coverage Δ
e2e 39.64% <ø> (+3.43%) ⬆️
e2e go 32.36% <ø> (-0.50%) ⬇️
e2e node 28.11% <ø> (-0.51%) ⬇️
e2e python 32.72% <ø> (-0.51%) ⬇️
e2e quarkus ?
e2e rust 27.65% <ø> (-0.54%) ⬇️
e2e springboot 26.15% <ø> (-0.50%) ⬇️
e2e typescript 28.25% <ø> (-0.48%) ⬇️
e2e-config-ci 17.55% <ø> (-0.51%) ⬇️
integration 17.07% <ø> (-0.51%) ⬇️
unit macos-14 42.69% <ø> (-0.62%) ⬇️
unit macos-latest 42.69% <ø> (-0.62%) ⬇️
unit ubuntu-24.04-arm 43.51% <ø> (ø)
unit ubuntu-latest 43.51% <ø> (-0.68%) ⬇️
unit windows-latest 42.71% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Use root-only *.md instead of **/*.md so template and testdata markdown still trigger CI. Replace CODEOWNERS with OWNERS and OWNERS_ALIASES to match repo ownership files.
@Ankitsinghsisodya Ankitsinghsisodya force-pushed the ci/paths-ignore-functions branch from 8ef272b to 15f5a96 Compare April 22, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test 🤖 Needs an org member to approve testing size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: skip functions workflow on doc-only changes

2 participants