fix: cancel correct debounced instance on unmount in useDebounceCallback#720
Open
haunc08 wants to merge 1 commit intojuliencrn:masterfrom
Open
fix: cancel correct debounced instance on unmount in useDebounceCallback#720haunc08 wants to merge 1 commit intojuliencrn:masterfrom
haunc08 wants to merge 1 commit intojuliencrn:masterfrom
Conversation
The unmount cleanup was cancelling a separate debounced instance created in useEffect rather than the actual instance used by callers (created in useMemo). Store the useMemo instance in the ref instead, and remove the redundant useEffect.
|
vascoteixeira-aurum
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
useUnmountcleanup inuseDebounceCallbackwas cancelling a separate debounced instance (created inuseEffect) instead of the actual instance used by callers (created inuseMemo). This meant pending debounced calls were never cancelled on unmount.Changes
debouncedFuncInstancefromuseMemoin the ref directly, souseUnmountcancels the correct instanceuseEffectthat created a separate unused debounced instance