Skip to content

Add clippy to CI#3153

Closed
palango wants to merge 3 commits intohyperium:masterfrom
palango:clippy
Closed

Add clippy to CI#3153
palango wants to merge 3 commits intohyperium:masterfrom
palango:clippy

Conversation

@palango
Copy link
Copy Markdown
Contributor

@palango palango commented Feb 28, 2023

Adds limited clippy run to CI.

There were two clippy warnings which seemed useful, they're in the second commit. If you don't like them I'm happy to drop the commit.

Resolves #2977
Superseeds #2979

@seanmonstar
Copy link
Copy Markdown
Member

Thank you! I'm still surprised this doesn't catch that there is an ext.rs and ext/ folder. When I noticed those two existed, that's why I filed the original issue. Am I misunderstanding what that lint catches?

@palango
Copy link
Copy Markdown
Contributor Author

palango commented Mar 1, 2023

Seems like there are some bugs in the lint: rust-lang/rust-clippy#8094

@palango palango force-pushed the clippy branch 2 times, most recently from 6560c97 to bd20988 Compare September 19, 2023 13:37
@palango palango closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add limited clippy to CI

2 participants