Replace "cfg(test)" with "cfg(doctest)" for readme testing#420
Open
GuillaumeGomez wants to merge 2 commits intohyperium:masterfrom
Open
Replace "cfg(test)" with "cfg(doctest)" for readme testing#420GuillaumeGomez wants to merge 2 commits intohyperium:masterfrom
GuillaumeGomez wants to merge 2 commits intohyperium:masterfrom
Conversation
seanmonstar
reviewed
May 7, 2020
| - stable | ||
| - beta | ||
| - nightly | ||
| - 1.39.0 |
Contributor
Author
There was a problem hiding this comment.
I can add a version detection for test builds and if too low, I will use "disable-doctest" feature (or another feature name) so you won't have build failures on versions lower than 1.40. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rustdoc now passes "doctest" when running in test mode.