fix: call to sanitize schema for complex union types#5366
fix: call to sanitize schema for complex union types#5366EugeneYushin wants to merge 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Response from ADK Triaging Agent Hello @EugeneYushin, thank you for your contribution! Before we can proceed with the review, could you please address the following points from the contribution guidelines?
Addressing these items will help us move forward with the review process. Thanks! |
|
Response from ADK Triaging Agent Hello @EugeneYushin, thank you for creating this PR! Before we can merge this, could you please sign our Contributor License Agreement (CLA)? You can do so here: https://cla.developers.google.com/ Also, could you please provide manual end-to-end (E2E) tests to help us verify the fix? This information will help reviewers to review your PR more efficiently. Thanks! |
|
Response from ADK Triaging Agent Hello @EugeneYushin, thank you for your contribution! Before we can merge this PR, we need to address a couple of items from our contribution guidelines:
You can find more information in our contribution guidelines. Thanks! |
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
Using python functions with dicts in its signature breaks Gemini schema.
Solution:
Sanitize schema same way it's done in McpTool
Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
Checklist
Additional context
Follow up: #5000