-
-
Notifications
You must be signed in to change notification settings - Fork 468
feat(android): Add queryable getFramesDelay API to SentryFrameMetricsCollector #5248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
44e21df
feat(android): Add queryable getFramesDelay API to SpanFrameMetricsCoโฆ
antonis 3e247bb
changelog
antonis 9f94607
revert changelog
antonis 6b99b10
Merge branch 'main' into feat/queryable-frames-delay-api
antonis 99acb6a
ref(android): Move getFramesDelay to SentryFrameMetricsCollector
antonis 2ee6e8c
Merge branch 'main' into feat/queryable-frames-delay-api
antonis cda5f94
Merge branch 'main' into feat/queryable-frames-delay-api
antonis 00431a5
fix: Off-by-one in buffer size check and compareTo tiebreaker for Delโฆ
antonis 1a28507
fix: Prune old frames before size check to avoid dropping new frames โฆ
antonis df1f7a6
fix(test): Make partial overlap test actually clip the delay interval
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
sentry-android-core/src/main/java/io/sentry/android/core/SentryFramesDelayResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package io.sentry.android.core; | ||
|
|
||
| import org.jetbrains.annotations.ApiStatus; | ||
|
|
||
| /** Result of querying frame delay for a given time range. */ | ||
| @ApiStatus.Internal | ||
| public final class SentryFramesDelayResult { | ||
|
|
||
| private final double delaySeconds; | ||
| private final int framesContributingToDelayCount; | ||
|
|
||
| public SentryFramesDelayResult( | ||
| final double delaySeconds, final int framesContributingToDelayCount) { | ||
| this.delaySeconds = delaySeconds; | ||
| this.framesContributingToDelayCount = framesContributingToDelayCount; | ||
| } | ||
|
|
||
| /** | ||
| * @return the total frame delay in seconds, or -1 if incalculable (e.g. no frame data available) | ||
| */ | ||
| public double getDelaySeconds() { | ||
| return delaySeconds; | ||
| } | ||
|
|
||
| /** | ||
| * @return the number of frames that contributed to the delay (slow + frozen frames) | ||
| */ | ||
| public int getFramesContributingToDelayCount() { | ||
| return framesContributingToDelayCount; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.