Fix getting config from git config#79
Open
fallen wants to merge 1 commit intogetpatchwork:mainfrom
Open
Conversation
stephenfin
requested changes
Apr 15, 2026
Member
stephenfin
left a comment
stephenfin
left a comment
There was a problem hiding this comment.
Thanks, this is a good catch. I have some small requests inlone
Currently the CLI will store to the Config object values from the argument parsing regardless of whether they are None or not. But if config.xxx is created, even with a None value the __getattr__ will never get called and thus will never lookup the git config value. The fix is to only store non-None values from the argument parsing to the Config object. Signed-off-by: Yann Sionneau <yann.sionneau@vates.tech> Co-authored-by: Stephen Finucane <stephen@that.guru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the CLI will store to the
Configobjectvalues from the argument parsing regardless of
whether they are
Noneor not.But if
config.xxxis created, even with a None value the__getattr__will never get called and thus will never lookup the git config value.The fix is to only store non-
Nonevalues from theargument parsing to the Config object.
Without this patch, doing
git pw series listwill never work, even if server and project are configured ingit config