Draft
Conversation
Also, introduce Colors and Typography to hold the material colors and the typography declarations. Previously we expected clients of these libraries to import them into a namespace, but that doesn't play nice with re-exporting them from material.dart.
Also, have dialog buttons use the accent colour. Also, generally rationalise some of this stuff to match Material better.
Add type annotations in many places. Fix some identifiers to have more lint-satisfying names. Make all operator==s consistent in style. Reorder some functions for consistency. Make ParentData no longer dynamic, and fix all the code around that.
Also: - give card_collection an option to turn on or off the edit widgets - give card_collection an option to control text alignment (when not editing) - give card_collection a "dump" option to aid debugging - make the gesture detector report which gestures it is listening to
Also, refactor more common code into RenderToggleable and handle dark themes more correctly. Fixes flutter#601
Properly paint disabled switches
Model ink splashes more physically
And fix the zillion issues that uncovered.
This reverts commit f41b341, reversing changes made to e33d8d9. This was a bad check-in due to my mangling uploading a new version of the branch from a different machine. This reverts flutter/flutter#2639 and will be replaced by flutter/flutter#2640
Revert "Merge pull request flutter#2639 from Hixie/always_specify_types"
And fix the zillion issues that uncovered.
Enable always_specify_types lint
Provide a list of Material design primary and accent color swatches
The dartdoc will continue until morale improves.
+ Add new demo to gallery to show data tables. (This currently doesn't use a Card; I'll create a Card version in a subsequent patch.) + Fix checkbox alignment. It now centers in its box regardless. + Add Colors.black54. + Some minor fixes to dartdocs. + DataTable, DataColumn, DataRow, DataCell + RowInkWell + Augment dartdocs of materia/debug.dart. + DropDownButtonHideUnderline to hide the underline in a drop-down when used in a DataTable. + Add new capabilities to InkResponse to support RowInkWell. + Augment dartdocs of materia/material.dart. + Add an assert to catch nested Blocks. + Fix a crash in RenderBox when you remove an object and an ancestor used its baseline. (flutter/flutter#2874) + Fix (and redocument) RenderBaseline/Baseline. + Add flex support to IntrinsicColumnWidth. + Document more stuff on the RenderTable side. + Fix a bug with parentData handling on RenderTable children. + Completely rewrite the column width computations. The old logic made no sense at all. + Add dartdocs to widgets/debug.dart. + Add a toString for TableRow.
Based on observations of usability study participant P1.
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
…0289) * fix deprecated_new_in_comment_reference for `material` library in a future version of the SDK, these will be flagged, fix them now * Update pubspec.yaml
Update links in the framework and fix data files to their newest, up-to-date destinations.
flutter/flutter#150800. I skipped files that contain generated code because the script isn't smart enough, and I did not fix some dubious comment refs. Those will be addressed in a different PR.
Adds files from flutter/flaux which contain modifications for the engine structure. The history for engine/ has been edited. Please see flutter/engine for the original PRs.
Hello Monorepo.
This auto-formats all *.dart files in the repository outside of the `engine` subdirectory and enforces that these files stay formatted with a presubmit check. **Reviewers:** Please carefully review all the commits except for the one titled "formatted". The "formatted" commit was auto-generated by running `dev/tools/format.sh -a -f`. The other commits were hand-crafted to prepare the repo for the formatting change. I recommend reviewing the commits one-by-one via the "Commits" tab and avoiding Github's "Files changed" tab as it will likely slow down your browser because of the size of this PR. --------- Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
…olors Copy in colors.dart and history.
github-actions
bot
added
triage-framework
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Is there a doc about how you are planning on doing the import? I've done quite a few history-preserving imports into flutter/packages, so I have experience with this process. I would strongly expect the import to be a single mega-PR, not a series of small PRs. We can temporarily opt the new packages out of some checks if necessary, and then do follow-up PRs to get everything working and opt them back in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm attempting to move a simple file with no dependencies from flutter/flutter's Material library to material_ui, in order to give us the change to test things like the batch release process, docs, etc.
I'm trying a very simple file after I was overwhelmed by ProgressIndicator in #11526.
TODOs