Closed
Conversation
This PR was created automatically to batch release the `go_router`.
This PR was created automatically to batch release the `go_router`.
This PR was created automatically to batch release the `go_router`.
fluttergithubbot
added
the
override: post-release-go_router
github-actions
Bot
added
p: go_router
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the go_router package to version 17.2.2 and includes a fix for pop() restoring stale configurations when using onExit. A critical issue was identified in the CHANGELOG.md file, which contains unresolved merge conflict markers that must be removed.
Comment on lines
+1
to
+7
| <<<<<<< go_router-24678095354-1 | ||
| ## 17.2.2 | ||
|
|
||
| - Fixes `pop()` restoring stale configuration when route has `onExit`, which could cause the popped route to reappear with async redirects. | ||
|
|
||
| ======= | ||
| >>>>>>> release-go_router |
There was a problem hiding this comment.
The CHANGELOG.md file contains unresolved merge conflict markers. Please resolve these by removing the markers and keeping the correct version entry.
Suggested change
| <<<<<<< go_router-24678095354-1 | |
| ## 17.2.2 | |
| - Fixes `pop()` restoring stale configuration when route has `onExit`, which could cause the popped route to reappear with async redirects. | |
| ======= | |
| >>>>>>> release-go_router | |
| ## 17.2.2 | |
| - Fixes pop() restoring stale configuration when route has onExit, which could cause the popped route to reappear with async redirects. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automated PR syncs the changes from the release branch release-go_router back to the main branch.