[browser] Export useful browser tuntime TypeScript types#127084
Open
elringus wants to merge 2 commits intodotnet:mainfrom
Open
[browser] Export useful browser tuntime TypeScript types#127084elringus wants to merge 2 commits intodotnet:mainfrom
elringus wants to merge 2 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Author
|
@dotnet-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes existing browser runtime asset-related TypeScript types publicly discoverable by re-exporting them from the intended top-level .d.ts entrypoints for both NativeAOT and Mono browser runtimes.
Changes:
- Re-export asset model types (e.g.,
Assets,Asset,AssemblyAsset,WasmAsset,WebAssemblyBootResourceType, etc.) from the NativeAOT public TypeScript entrypoint. - Re-export the same asset model types from the Mono browser runtime public TypeScript entrypoint, aligning the two runtimes’ public surfaces.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/libs/Common/JavaScript/types/export-api.ts | Extends the NativeAOT top-level type entrypoint to re-export the asset model types from public-api. |
| src/mono/browser/runtime/types/export-types.ts | Extends the Mono browser runtime top-level type entrypoint to re-export the same asset model types from the runtime types/index. |
Member
|
@elringus please
it will generate 2x |
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exports the browser asset-related types from the public TypeScript entrypoints for both Mono and CoreCLR.
These types were already defined in the underlying runtime type declarations, but they were not consistently re-exported from the public API surfaces. This change makes them available to consumers in both runtimes through the intended top-level type export files.
This improves the usability of the browser runtime TypeScript APIs by making the existing asset model types discoverable and importable without reaching into internal type declaration files.
The issue was discussed with @pavelsavara on .NET's Discord server.