new module properties#215
Open
raphael-goetz wants to merge 2 commits intomainfrom
Open
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/draco/-/pipelines/2485892542 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14126374275/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Draco’s runtime status reporting to align with the newer tucana API for “module properties” by switching from RuntimeFeature/AdapterConfiguration to AdapterStatusConfiguration, and bumps workspace dependencies accordingly (Issue #212).
Changes:
- Refactors
ServerRunner::serveandDracoRuntimeStatusServiceto sendAdapterStatusConfigurationonly (removing runtime features). - Updates REST and CRON adapters to use the new
serve(configs)signature and build the new configuration payload. - Bumps
code0-flowto0.0.33andtucanato0.0.70.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/base/src/runner.rs | Changes serve API to accept only AdapterStatusConfiguration and forwards it into runtime status reporting. |
| crates/base/src/client/mod.rs | Adjusts runtime status update payload to include only configurations (new config type). |
| adapter/rest/src/main.rs | Builds and reports REST endpoint configuration via AdapterStatusConfiguration. |
| adapter/cron/src/main.rs | Updates call-site for new serve signature (currently passes empty config list). |
| Cargo.toml | Dependency bumps for code0-flow and tucana. |
| Cargo.lock | Lockfile updates to reflect dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #212