Skip to content

new module structure#149

Merged
raphael-goetz merged 6 commits intomainfrom
#147-new-module-structure
Apr 28, 2026
Merged

new module structure#149
raphael-goetz merged 6 commits intomainfrom
#147-new-module-structure

Conversation

@raphael-goetz
Copy link
Copy Markdown
Member

Resolves: #147

Copilot AI review requested due to automatic review settings April 27, 2026 16:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements the new “module” based definition layout (Issue #147) by changing the definition reader to load modules (with optional module.json) and updating the Aquila update service to send modules in a single request.

Changes:

  • Replace per-definition-type Aquila updates (data types / functions / flow types) with a single module update call.
  • Update the filesystem reader to discover module directories and load module-scoped definitions (including runtime flow types and configurations).
  • Bump tucana dependency to 0.0.69 (and lockfile updates).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/flow_service/mod.rs Switches FlowUpdateService to read/send Module definitions via ModuleServiceClient.
src/flow_definition/mod.rs Adds module discovery + loading (module.json, definition subdirs) and exposes read_modules().
src/flow_definition/feature/version.rs Extends version filtering support to RuntimeFlowType.
Cargo.toml Updates tucana dependency version.
Cargo.lock Lockfile refresh for the dependency update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/flow_definition/mod.rs
Comment thread src/flow_service/mod.rs Outdated
Comment thread src/flow_service/mod.rs Outdated
raphael-goetz and others added 2 commits April 27, 2026 19:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
@raphael-goetz raphael-goetz merged commit e7727df into main Apr 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement module structure

2 participants