new module structure#149
Merged
raphael-goetz merged 6 commits intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the new “module” based definition layout (Issue #147) by changing the definition reader to load modules (with optional module.json) and updating the Aquila update service to send modules in a single request.
Changes:
- Replace per-definition-type Aquila updates (data types / functions / flow types) with a single module update call.
- Update the filesystem reader to discover module directories and load module-scoped definitions (including runtime flow types and configurations).
- Bump
tucanadependency to0.0.69(and lockfile updates).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/flow_service/mod.rs |
Switches FlowUpdateService to read/send Module definitions via ModuleServiceClient. |
src/flow_definition/mod.rs |
Adds module discovery + loading (module.json, definition subdirs) and exposes read_modules(). |
src/flow_definition/feature/version.rs |
Extends version filtering support to RuntimeFlowType. |
Cargo.toml |
Updates tucana dependency version. |
Cargo.lock |
Lockfile refresh for the dependency update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #147