5.x.x app features#1351
Conversation
|
@Kehrlann ping |
|
(I'm currently off sick, will run the integration test next week.) |
| import org.cloudfoundry.operations.applications.TaskState; | ||
| import org.cloudfoundry.operations.applications.TerminateApplicationTaskRequest; | ||
| import org.cloudfoundry.operations.applications.UnsetEnvironmentVariableApplicationRequest; | ||
| import org.cloudfoundry.operations.applications.*; |
There was a problem hiding this comment.
The imports are broken, please revert to explicit imports and just add what you need.
| this.cloudFoundryOperations | ||
| .applications() | ||
| .getApplicationManifest( | ||
| GetApplicationManifestRequest.builder() | ||
| .name(applicationName) | ||
| .build())) |
There was a problem hiding this comment.
This does not return ApplicationFeatures (it's null), because this getApplicationManifest is a synthetic manifest build by CFJC itself (source)
You want to either:
- Update operations to get the app features and put them in the manifest
- Update the test to use the v3 features API to list features and check the result.
aegliv
force-pushed
the
5.x.x-app-features
branch
from
68db5e3 to
57a9ba0
Compare
aegliv
force-pushed
the
5.x.x-app-features
branch
from
57a9ba0 to
bccf442
Compare
| /** | ||
| * Manage whether optional capabilities are enabled | ||
| */ | ||
| @AllowNulls | ||
| @Nullable | ||
| abstract Map<String, Object> getFeatures(); |
There was a problem hiding this comment.
features don't seem to work with manifest v2 at all.
Only add it to manifest v3
| } | ||
|
|
||
| @Test | ||
| public void pushAppFeatures() throws IOException { |
There was a problem hiding this comment.
The tests do not break anymore.
However, the features are not pushed, because .pushApplicationManifest v2 does not actually push a manifest, it does a few manual push app operations. You need to use manifest v3 only.
2 participants
Implements #1263