Create/Update route options#1339
Conversation
Refactor _RouteOptions class to handle added options in future
|
@Kehrlann Is it necessary something else to be added before code review to be done? |
|
|
||
| /** | ||
| * The loadbalancing | ||
| * All route options, including unknown future keys. |
There was a problem hiding this comment.
That's not a pattern we use anywhere, I don't think we should introduce it unless we have a very good reason to have it for this one specific sub-resource.
Otherwise, let's just add the hashes for now.
There was a problem hiding this comment.
The reason why this pattern is used is because the client library doesn't keep up well with all new features introduced in Cloudfoundry API and it's annoying that consumers of cf-java-client library cannot use latest available features until it's contributed and released. So if there is an option to make some logic more generic, I think it's better for all users. What do you think?
There was a problem hiding this comment.
This is an interesting idea, but I don't want to add it on a class-by-class basis. Is there a way to add it to our Immutables and-or JSON config?
2 participants
Refactor _RouteOptions class to handle added options in future