[GOBBLIN-1674] : Add an option in gobblin.sh to specify whether to run the Gobblin job in background or not#3534
Open
bharos wants to merge 1 commit intoapache:masterfrom
Open
[GOBBLIN-1674] : Add an option in gobblin.sh to specify whether to run the Gobblin job in background or not#3534bharos wants to merge 1 commit intoapache:masterfrom
bharos wants to merge 1 commit intoapache:masterfrom
Conversation
…n the Gobblin job in background or not Currently, the command uses 'nohup' and '&' which always makes it run in background. This makes it inconvenient in use-cases that need to do some action after the run is completed (like curling for some logs). Hence, providing an option to choose whether to run in background or not.
Member
|
+1 It looks good to me. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3534 +/- ##
============================================
- Coverage 46.69% 46.68% -0.01%
- Complexity 10432 10436 +4
============================================
Files 2083 2083
Lines 81516 81516
Branches 9100 9100
============================================
- Hits 38061 38056 -5
- Misses 39944 39946 +2
- Partials 3511 3514 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Will-Lo
approved these changes
Aug 8, 2022
Contributor
|
@bharos Could you rebase from master? It conflicts with the previous changes that you've made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Currently, the command uses 'nohup' and '&' which always makes it run in background.
This makes it inconvenient in use-cases that need to do some action after the run is
completed (like curling for some logs). Hence, providing an option to choose whether
to run in background or not.
Tests
Tested in local environment with the new flag, unit tests Not applicable.
Commits