Skip to content

GOBBLIN-474: Add end-of-datasets marker to workunit correctly to avoid an additional run when end of datasets is reached.#2346

Open
sv2000 wants to merge 1 commit intoapache:masterfrom
sv2000:endOfDatasetsMarker
Open

GOBBLIN-474: Add end-of-datasets marker to workunit correctly to avoid an additional run when end of datasets is reached.#2346
sv2000 wants to merge 1 commit intoapache:masterfrom
sv2000:endOfDatasetsMarker

Conversation

@sv2000
Copy link
Copy Markdown
Contributor

@sv2000 sv2000 commented Apr 24, 2018

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    When the number of maximum workunits per run setting in LoopingDatasetFinderSource equals the number of remaining datasets to process before the end of the loop, we do not place the "End-of-Dataset" marker in the last workunit. The subsequent run turns out to be essentially a no-op and is avoidable by correctly detecting the end-of-datasets.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Added a unit test.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

…d an additional run when end of datasets is reached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant