FINERACT-2592: It does not allow rescheduling.

[EDSONZ-WASSWA]

Description

Background
When a borrower misses several payments, Fineract calculates penalty charges on each overdue installment. Up until this change, attempting to reschedule such a loan would fail immediately with a not.allowed.due.to.overdue.charges validation error, making it impossible to help borrowers who genuinely needed their repayment schedule restructured.
This was a real gap the most common reason a lender reschedules a loan is precisely because the borrower has fallen behind.

What this PR does
The system used to stop loan rescheduling completely whenever overdue penalty charges existed. Now it doesn't have to.
There's a new optional flag " waiveOverdueCharges" that a lender can pass when approving a reschedule. Set it to true and the system clears all outstanding overdue penalties right before building the new repayment schedule.
This practically makes sense:
when restructuring a loan, the lender usually wants to clear those penalties as part of the deal, so this just handles it in one step instead of two.
Leave the flag out or set it to false and nothing changes the original block stays in place. No decision made, no charges touched.
For the actual waiving, it hooks straight into the existing charge waiver logic, so you get the same audit trail and transaction records as a manual waiver through the User interface (UI).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.
this is the link to the jira ticket https://mifosforge.jira.com/issues?filter=-1&selectedIssue=WEB-479

[adamsaghy]

@EDSONZ-WASSWA We are not accepting WEB Jira ticket for backend changes. Please create an appropriate Apache Fineract JIRA ticket for this changes!

[IOhacker]

@EDSONZ-WASSWA make sure you have signed your commits

[IOhacker]

@EDSONZ-WASSWA please rebase

[Aman-Mittal]

@EDSONZ-WASSWA I need to open more discussion about the intended use-case.

Please correct me if im wrong - You are passing a flag that is forcefully waiving off the dues.

Using flag for this usecase is making me uneasy - i know that it is capturing audit trail but it doesn't capture why it waived off.

Also can you tell me how user waive of the dues in current fineract system?

It seems like regulatory/compliance risk to me if we are not doing proper reporting for waiver

@adamsaghy @IOhacker your thought required on this based on use case perspective. In Banking industry what is the proper business process for waiving overdue charges.

[adamsaghy]

@EDSONZ-WASSWA I need to open more discussion about the intended use-case.

Please correct me if im wrong - You are passing a flag that is forcefully waiving off the dues.

Using flag for this usecase is making me uneasy - i know that it is capturing audit trail but it doesn't capture why it waived off.

Also can you tell me how user waive of the dues in current fineract system?

It seems like regulatory/compliance risk to me if we are not doing proper reporting for waiver

@adamsaghy @IOhacker your thought required on this based on use case perspective. In Banking industry what is the proper business process for waiving overdue charges.

Lets move this discussion to fineract dev mail list

[Aman-Mittal]

@EDSONZ-WASSWA I need to open more discussion about the intended use-case.
Please correct me if im wrong - You are passing a flag that is forcefully waiving off the dues.
Using flag for this usecase is making me uneasy - i know that it is capturing audit trail but it doesn't capture why it waived off.
Also can you tell me how user waive of the dues in current fineract system?
It seems like regulatory/compliance risk to me if we are not doing proper reporting for waiver
@adamsaghy @IOhacker your thought required on this based on use case perspective. In Banking industry what is the proper business process for waiving overdue charges.

Lets move this discussion to fineract dev mail list

hi @adamsaghy Initiated discussion at https://lists.apache.org/thread/cmlw0lcl2xzdlbc292gk0qrymzs64kz2

[EDSONZ-WASSWA]

@EDSONZ-WASSWA I need to open more discussion about the intended use-case.
Please correct me if im wrong - You are passing a flag that is forcefully waiving off the dues.
Using flag for this usecase is making me uneasy - i know that it is capturing audit trail but it doesn't capture why it waived off.
Also can you tell me how user waive of the dues in current fineract system?
It seems like regulatory/compliance risk to me if we are not doing proper reporting for waiver
@adamsaghy @IOhacker your thought required on this based on use case perspective. In Banking industry what is the proper business process for waiving overdue charges.

Lets move this discussion to fineract dev mail list

hi @adamsaghy Initiated discussion at https://lists.apache.org/thread/cmlw0lcl2xzdlbc292gk0qrymzs64kz2

@adamsaghy @Aman-Mittal I am unable to sign into the mail list, It says the 2f Authentication is down ["Please note: Two-factor authentication has been temporarily disabled while we rework the overall design of this feature"]

[Aman-Mittal]

@EDSONZ-WASSWA I need to open more discussion about the intended use-case.
Please correct me if im wrong - You are passing a flag that is forcefully waiving off the dues.
Using flag for this usecase is making me uneasy - i know that it is capturing audit trail but it doesn't capture why it waived off.
Also can you tell me how user waive of the dues in current fineract system?
It seems like regulatory/compliance risk to me if we are not doing proper reporting for waiver
@adamsaghy @IOhacker your thought required on this based on use case perspective. In Banking industry what is the proper business process for waiving overdue charges.

Lets move this discussion to fineract dev mail list

hi @adamsaghy Initiated discussion at https://lists.apache.org/thread/cmlw0lcl2xzdlbc292gk0qrymzs64kz2

@adamsaghy @Aman-Mittal I am unable to sign into the mail list, It says the 2f Authentication is down ["Please note: Two-factor authentication has been temporarily disabled while we rework the overall design of this feature"]

@EDSONZ-WASSWA Send mail to dev-subscribe@fineract.apache.org you will then receive mails from dev list

[adamsaghy]

@EDSONZ-WASSWA Please review the failing checks:

Please run:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
./gradlew --no-daemon build -x test -x cucumber -x doc

Before any PR or changes, please always run these two commands and make sure there is green build!

[jdailey]

@EDSONZ-WASSWA - I would recommend that you follow the project for a period of time. Review other commits, get to know the way things are done. Understand the lifecycle of jira tickets. Jumping into this with without the context is difficult and counter productive. After a few weeks or months of doing that, then suggest a small change linked to a ticket that is legit. Make sure it passes all tests before you raise it. Discuss on list if you think you have a significant requirement that isn't met. Sometimes correcting one thing can be problematic for other features.