perf(ci): run unit-tests in parallel with build in frontend-pr-workflow#231
Merged
kb-typeform merged 1 commit intomainfrom Apr 23, 2026
Merged
perf(ci): run unit-tests in parallel with build in frontend-pr-workflow#231kb-typeform merged 1 commit intomainfrom
kb-typeform merged 1 commit intomainfrom
Conversation
Unit tests don't consume the build artifact and re-run any codegen via pre-test-command, so needs: build only serialized the pipeline. Removing it lets unit-tests run in parallel with build for faster PR feedback. This is a test branch for validating the change against performance-analytics (the one repo where Turbo cache warmup could interact with parallel execution). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
alexkravch
approved these changes
Apr 23, 2026
|
This PR is missing a Jira ticket reference in the title or description. |
|
🥷 Code experts: no user but you matched threshold 10 kb-typeform, zdenekkostal have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
needs: buildfrom theunit-testsjob infrontend-pr-workflow.yml.unit-testsdoes not consume the build artifact (noDownload Build Artifactsstep, noneeds.build.outputs.*reference) and already re-runs any required codegen inpre-test-command. The dependency only serialized the pipeline for no functional gain.unit-testsruns in parallel withbuild, shortening PR feedback time.Scope
Investigated all 32 frontend repos migrated to the unified CI pipeline (PLT-2547):
pre-test-command: yarn generatethat is self-contained (smart-forms-builder, audiences-page, admin-panel, followups-manager, typeform-ai, authbridge-fe, auth-page, boombox-fe, cha-ching, hall-of-forms, paprikations, typekit-app-directory, share-web, workflows, results, integrations-panel, chief, demo-app).pre-test-commandindependently of thebuildjob, so removing the dep is safe.Validation
End-to-end test against
performance-analytics(the repo with the most complex pre-test — Turbo workspace rebuilds + GraphQL codegen):@test/unit-tests-no-build-dep.Time savings on this PR: ~3m48s on the unit-tests critical path (equal to the full build duration, because unit-tests > build here). For repos where unit-tests < build, savings equal the unit-tests duration on any path that gates on unit-tests completion (e.g. SonarCloud, which currently
needs: [build, unit-tests]).Flakes observed during validation were pre-existing (intermittent GraphQL schema fetches, Playwright timeouts) and reproduce on unmodified PRs.
Test plan
🤖 Generated with Claude Code