(Please Review Before 2.0 releases!) Remove need to use Box::pin for transactions.#3053
(Please Review Before 2.0 releases!) Remove need to use Box::pin for transactions.#3053landonpoch wants to merge 1 commit intoSeaQL:masterfrom
Conversation
|
@tyt2y3 - I know you guys are pretty far along in the RC process at this point. I just want to make sure you get some eyes on this to see if it could make the cut. This would be a really nice thing to include as it makes using the api a lot easier. |
|
The problem with this PR is that, as @Huliiiiii wrote, you can not specify the |
|
@ProbstDJakob - Got it. Waiting for CallOnceFuture is probably the move then. Once that is in, I can update this to add the Send contraint and then it should be ready to go. Oh well. |
|
would be nice if this works on stable! |
PR Info
With rust >= 1.85 we shouldn't need to Box::pin async closures anymore. This fixes that. I'm hoping you'll accept this because it is a breaking change and 2.0 is in RC right now. This would be timely to get it in prior to a major upgrade.
New Features
Bug Fixes
Breaking Changes
Note!!! If you don't want this as a breaking change consider modifying this PR to just create new methods for this and leave the old stuff in tact. However, I think it's much better just to rip the bandaid off in this release.