[Enhancement] Removed mLabelRotatedWidth/Height variables from XAxis model.#4032
Open
RobertZagorski wants to merge 1 commit intoPhilJay:masterfrom
Open
Conversation
Those 2 variables were used only if mLabelRotationAngle was different than 0. In such situation mLabelWidth/Height became unused. This was removes this unnecessary overhead - merges those two cases into one making use of mLabelWidth/Height variables in XAxis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
Added a case for one of example charts.
PR Description
There are 2 variables in
XAxismodel:mLabelRotatedWidthmLabelRotatedHeightTheir existence is unjustified. Those 2 variables were used only if mLabelRotationAngle was different than 0. In such situation mLabelWidth/Height became unused. This PR was removes this unnecessary overhead - merges those two cases into one - making use of mLabelWidth/Height variables in XAxis.