optionally render stacked bar chart values with text color that match…#3809
optionally render stacked bar chart values with text color that match…#3809mtotschnig wants to merge 8 commits intoPhilJay:masterfrom
Conversation
|
Please review this commit and merge to fix the value text colors as soon as possible, we need this. |
almic
left a comment
almic
left a comment
There was a problem hiding this comment.
Variable names should align with the current code style, starting with the letter 'm'.
You may also consider changing the name to something shorter and easier to type, like setValuesUseBarColor().
Also, there is no need to create the getStackTextColors(), that exact method already exists in BaseDataSet: dataSet.getColors() And the boolean variable inside the new method can just be called enabled, not the name of the function.
Last thing, the partner function isValuesUseBarColor() must exist, and return the boolean. That is how you should check if the option is enabled. As well, the option needs to be false by default, I suggest explicitly writing that into the member declaration.
…names, reuse already defined getColors method, add getter
|
@almic I have taken into account all your suggestions, with the exception of "And the boolean variable inside the new method can just be called enabled, not the name of the function.", which I do not understand. |
…ial NPEs we pull the decision up into the interface
# Conflicts: # MPChartLib/src/main/java/com/github/mikephil/charting/data/BarDataSet.java # MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.java
3 participants
…es data color
fixes #2460