Fix "closestToY" functionality in DataSet.getEntryIndex#3463
Open
Jetz72 wants to merge 1 commit intoPhilJay:masterfrom
Open
Fix "closestToY" functionality in DataSet.getEntryIndex#3463Jetz72 wants to merge 1 commit intoPhilJay:masterfrom
Jetz72 wants to merge 1 commit intoPhilJay:masterfrom
Conversation
getEntryIndex has a "closestToY" parameter that appears to be for disambiguating cases where points have the same X value but different Y positions. The loop that searches entries with matching X values for the closest Y value is bugged, and will not correctly locate the nearest entry due to a bug on line 362. This corrects that behavior, and consequently, allows the user to select the intended point when several entries have the same X value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getEntryIndex has a "closestToY" parameter that appears to be for disambiguating cases where points have the same X value but different Y positions. The loop that searches entries with matching X values for the closest Y value is bugged, and will not correctly locate the nearest entry due to a bug on line 362. This corrects that behavior, and consequently, allows the user to select the intended point when several entries have the same X value.