[2.9] task: tighten AUTO read-ahead wait-clear to match MDI#3973
Draft
grandixximo wants to merge 1 commit intoLinuxCNC:2.9from
Draft
[2.9] task: tighten AUTO read-ahead wait-clear to match MDI#3973grandixximo wants to merge 1 commit intoLinuxCNC:2.9from
grandixximo wants to merge 1 commit intoLinuxCNC:2.9from
Conversation
Auto mode cleared the read-ahead wait on execState==DONE alone, so a G38 issued just before an emcMotionUpdate snapshot could let the next read fire while motion.traj.queue was still non-zero, tripping NCE_QUEUE_IS_NOT_EMPTY_AFTER_PROBING. Add the queue==0 + io.status ==DONE conjuncts already used by mdi_execute_hook. Closes LinuxCNC#3650, LinuxCNC#662, LinuxCNC#263.
Author
|
Just here so users can do testing on 2.9 as well, for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.9 backport of #3971.
Cherry-pick of af6b5b7 with trivial conflict fixup for the pre-scoped-enum identifiers on 2.9 (
EMC_TASK_EXEC_DONE,RCS_DONE).Closes #3650, #662, #263.