Skip to content

feat(workflows): add execute with and without arguments#10255

Draft
alarconesparza wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
alarconesparza:alarconesparza-update-workflows-507097366
Draft

feat(workflows): add execute with and without arguments#10255
alarconesparza wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
alarconesparza:alarconesparza-update-workflows-507097366

Conversation

@alarconesparza
Copy link
Copy Markdown
Contributor

@alarconesparza alarconesparza commented Apr 29, 2026

Description

Fixes internal b/507097366

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples. labels Apr 29, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Google Cloud Workflow definition along with Java samples for executing workflows with and without arguments. It also includes integration tests and a utility class for workflow management. The review feedback focuses on optimizing the test utility class by removing redundant manual polling loops in favor of blocking on the OperationFuture returned by asynchronous client methods and improving exception handling in test helpers to promote fail-fast behavior.

Comment thread workflows/cloud-client/src/test/java/com/example/workflows/Utils.java Outdated
Comment thread workflows/cloud-client/src/test/java/com/example/workflows/Utils.java Outdated
@alarconesparza
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Google Cloud Workflow definition along with Java samples and integration tests for executing workflows with and without arguments. The review feedback identifies several opportunities for code cleanup, specifically regarding unused imports and unnecessary exception declarations in the execution classes. Additionally, there is a recommendation to improve the file reading logic in the test utilities to ensure consistent character encoding and to utilize more modern Java APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant