feat(workflows): add execute with and without arguments#10255
feat(workflows): add execute with and without arguments#10255alarconesparza wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new Google Cloud Workflow definition along with Java samples for executing workflows with and without arguments. It also includes integration tests and a utility class for workflow management. The review feedback focuses on optimizing the test utility class by removing redundant manual polling loops in favor of blocking on the OperationFuture returned by asynchronous client methods and improving exception handling in test helpers to promote fail-fast behavior.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new Google Cloud Workflow definition along with Java samples and integration tests for executing workflows with and without arguments. The review feedback identifies several opportunities for code cleanup, specifically regarding unused imports and unnecessary exception declarations in the execution classes. Additionally, there is a recommendation to improve the file reading logic in the test utilities to ensure consistent character encoding and to utilize more modern Java APIs.
Description
Fixes internal b/507097366
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only