GPII-2748: Removed the translation from preferences->settingControls from PCP Channel#576
Open
kaspermarkus wants to merge 5 commits intoGPII:masterfrom
Open
GPII-2748: Removed the translation from preferences->settingControls from PCP Channel#576kaspermarkus wants to merge 5 commits intoGPII:masterfrom
kaspermarkus wants to merge 5 commits intoGPII:masterfrom
Conversation
… of 'preferences' path when reciving an update to the settings
|
CI job passed: https://ci.gpii.net/job/universal-tests/632/ |
Member
Author
|
The Astea team will do the initial round of reviews, antranig will give it a final lookover |
danailbd
approved these changes
Dec 8, 2017
georgitodorov
approved these changes
Dec 11, 2017
|
CI job failed: https://ci.gpii.net/job/universal-tests/1215/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1216/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1217/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1219/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1222/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1225/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1233/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request builds on #572 so it is only the changes in PCPClient and the bottom two blocks of deletions in PCPChannel that needs to be reviewed