clang-tidy 22 outputs "Error: no checks enabled." by default

[sean-mcmanus]

clang-tidy 22 removed clang-analyzer-* as a default check and clang-diagnostic-* doesn't count due to llvm/llvm-project#34763 .

We can add --allow-no-checks to allow just clang-diagnostic-* to be used without it failing.

[bobbrow]

Or do you want to enable clang-analyzer-* as a default check in our settings? (C_Cpp.codeAnalysis.clangTidy.checks.enabled) Users can remove it when they edit settings if they want. Either way is fine with me.

[sean-mcmanus]

Actually, --allow-no-checks doesn't work -- it incorrectly causes clang-diagnostic-* to also not run, even though it's supposed to be.

@bobbrow Yes, it appears we may want to just add clang-analyzer back as a default.

[bobbrow]

Probably need to update here too since the default won't be undefined anymore?

vscode-cpptools/Extension/src/LanguageServer/settings.ts

Line 348 in ecf1231

public get clangTidyChecksEnabled(): string[] | undefined { return this.getAsArrayOfStringsOrUndefined("codeAnalysis.clangTidy.checks.enabled", true); }

[sean-mcmanus]

@bobbrow I was going to set the --checks=clang-analyzer-* internally in cpptools when no other checks was used.